/var/www/restricted/ssh/stm32/www/stm32circle/ STM CircleOS forum / Small errors left...

Username:     
Password:     
             

Forum

# 1   2008-07-22 11:29:05 Small errors left...

qwertzguy
New member
Registered: 2008-07-03
Posts: 1

Small errors left...

Hello Francis,

There are still some little mistakes left in your excellent tutorial.
As Dale had said:
Page 9, section 2.2, 3rd paragraph:  "definition/declations" should be "definitions/declarations"
Page 12, 4th code example:  "Int Current_Height - SQUARE_WIDTH;" should be "int Current_Height = SQUARE_WIDTH;" and should be placed on page 15 below the line: "s16 Current_Pos = ( SCREEN_HEIGHT - SQUARE_WIDTH ) / 2;".

New errors:
Page 15, code section: "DRAW_SetDefaultColor ();" and "DRAW_Clear();" should be removed.
Page 18, since there is only one extra carriage returns I suggest you put the comment on two lines like:
"LCD_SetScreenOrientation ( V12 ) ; //Fix the orientation to
  //match with the MEMS information."

And I suggest to add after each paragraph saying to copy the previous stepX.c that the person should also modify the name of the application in the source code, otherwise the old name is shown in the menu and the persons might think it is a bug.


A very good tutorial! Thank you.

Offline

 

# 2   2008-07-28 07:08:35 Small errors left...

Francis
Administrator
From: France-Grenoble
Registered: 2007-07-09
Posts: 890

Re: Small errors left...

Thanks for your feedback. I am going to report these fixes.

Francis

Offline

 

# 3   2008-07-28 08:22:42 Small errors left...

Francis
Administrator
From: France-Grenoble
Registered: 2007-07-09
Posts: 890

Re: Small errors left...

I fixed the language errors.
For the last one:
  <<Page 15, code section: "DRAW_SetDefaultColor ();" and "DRAW_Clear();" should be removed.>>

These lines are present in the step3.c file.  Do you mean that these lines are useless ? Does the code work 'better' without these lines ?

Thanks

Francis

Offline

 

Board footer